Moved code to src/ and added docker info.#33
Open
micheas wants to merge 1 commit intoelijaa:masterfrom
Open
Conversation
This is mostly a code reorganization to simplify building the docker image. It also has a small fix for xss checking in src/Library/Bootstrap.php that recursively checks values that are passed in as an array instead of skipping them. This is a first pass to make it easy for developers to get this up and running on their local machines without needing to know too much about how to set up a php application.
Contributor
|
maybe you can rename this to |
Author
|
Devs at a previous employer were using it without issue while I was there without issue. I’ll look at it and see, but my memory is that it was working fine. Changes at this point would be style issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first pass, and any comments would be appreciated.
This is mostly a code reorganization to simplify building the
docker image.
It allows the initial groups/clusters to be set via environment variables
using the following format:
The docker-compose.yml file is another example of how to optionally
pass in default values.
It also has a small fix for xss checking in src/Library/Bootstrap.php
that recursively checks values that are passed in as an array instead
of skipping them.
This is a first pass to make it easy for developers to get this up
and running on their local machines without needing to know too
much about how to set up a php application, and easy for there to be
a set of default configs that "just work" without needing to burn a new
docker image.