Refactor GitHub workflows to use local workflow files and update depe…#51
Refactor GitHub workflows to use local workflow files and update depe…#51elendil-software merged 7 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors GitHub workflows to move from external workflow dependencies (from elendil-software/github-actions repository) to local workflow files, and updates action dependencies to specific versions.
Changes:
- Replaces external workflow calls with local workflow files (sw_build.yml and sw_tag-release.yml)
- Removes the Push-Dev-Nuget.yml workflow file
- Updates Pull-Request-Labeler action from v3 to v5.0.0
- Adds inline NuGet push job to Release workflow
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| IPX800cs.sln | Updates solution to reference new workflow files (sw_tag-release.yml, sw_build.yml, Pre-version.yml) and removes Push-Dev-Nuget.yml |
| .github/workflows/sw_tag-release.yml | New reusable workflow for creating tags and releases with artifact handling |
| .github/workflows/Release.yml | Refactored to use local sw_build.yml and sw_tag-release.yml workflows, adds inline NuGet push job |
| .github/workflows/Push-Dev-Nuget.yml | Removed workflow (no longer needed) |
| .github/workflows/Pull-Request.yml | Refactored to use local sw_build.yml workflow |
| .github/workflows/Pull-Request-Labeler.yml | Updates pr-labeler-action from v3 to v5.0.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
elendil-software
force-pushed
the
chore/fix-pipelines
branch
from
e647e04 to
c815a6b
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.github/workflows/sw_tag-release.yml
Outdated
| needs: [ release ] | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Push .nupkg files to nuget.org | ||
| run: dotnet nuget push ${{ inputs.artifact_name_in }}/*.nupkg --api-key $API_KEY --source https://api.nuget.org/v3/index.json | ||
| env: | ||
| API_KEY: ${{ secrets.NUGET_API_KEY }} No newline at end of file |
There was a problem hiding this comment.
This job structure is incorrect. The "needs" keyword and "steps" are defined at the same level, which is invalid GitHub Actions syntax. The "needs: [ release ]" line suggests this should be a separate job, not steps within the "release" job. This will cause the workflow to fail as it's attempting to reference itself in the "needs" clause.
This should either be:
- A separate job named something like "push-nuget" that depends on the "release" job, OR
- An additional step within the existing "release" job (without the "needs" keyword).
| needs: [ release ] | |
| runs-on: ubuntu-latest | |
| steps: | |
| - name: Push .nupkg files to nuget.org | |
| run: dotnet nuget push ${{ inputs.artifact_name_in }}/*.nupkg --api-key $API_KEY --source https://api.nuget.org/v3/index.json | |
| env: | |
| API_KEY: ${{ secrets.NUGET_API_KEY }} | |
| run: dotnet nuget push ${{ inputs.artifact_name_in }}/*.nupkg --api-key $API_KEY --source https://api.nuget.org/v3/index.json | |
| env: | |
| API_KEY: ${{ secrets.NUGET_API_KEY }} |
.github/workflows/sw_build.yml
Outdated
| with: | ||
| name: CoverageReport | ||
| path: coveragereport | ||
| retention-days: ${{ inputs.artifacts_retention_days }} |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
.github/workflows/sw_build.yml
Outdated
| uses: actions/upload-artifact@v4.3.4 | ||
| with: | ||
| name: CoverageReport | ||
| path: coveragereport | ||
| retention-days: ${{ inputs.artifacts_retention_days }} | ||
|
|
||
| - name: 'Upload source artifact' | ||
| if: ${{ inputs.push_artifact == true }} | ||
| uses: actions/upload-artifact@v4.5.0 |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
.github/workflows/sw_build.yml
Outdated
| with: | ||
| name: ${{ inputs.artifact_name_out }} | ||
| path: ./Output/IPX800cs/*.nupkg | ||
| retention-days: ${{ env.artifacts_retention_days }} |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
.github/workflows/Pre-version.yml
Outdated
| @@ -0,0 +1,10 @@ | |||
| name: 'Push Developement NuGet' | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…fix-pipelines # Conflicts: # .github/workflows/Release.yml # .github/workflows/sw_tag-release.yml
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ndencies