Fix output alteration in command factory for IPX800 v3 delayed outputs#50
Merged
elendil-software merged 1 commit intomainfrom Jan 24, 2026
Merged
Fix output alteration in command factory for IPX800 v3 delayed outputs#50elendil-software merged 1 commit intomainfrom
elendil-software merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request fixes a critical bug in the IPX800 V3 HTTP command builder where the output number was being incorrectly modified using a pre-decrement operator (--output.Number) instead of a subtraction expression (output.Number-1). The fix ensures that the output object passed to the command builder is not altered as a side effect, while still generating the correct command string for delayed outputs.
Changes:
- Fixed the output alteration bug by replacing pre-decrement operator with subtraction expression in IPX800V3SetOutputHttpCommandBuilder
- Added test assertions to verify that output objects are not modified by command factory methods
- Fixed parameter naming inconsistency (inputType → outputType) in test method
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| IPX800cs/Commands/Builders/v3/Http/IPX800V3SetOutputHttpCommandBuilder.cs | Fixed bug where --output.Number was mutating the output object; replaced with output.Number-1 to compute the value without side effects |
| IPX800cs.Test/Commands/Builders/CommandFactoryTest.cs | Added helper method AssertOutputIsNotAltered and integrated it into output command tests to prevent regression; also fixed parameter naming from inputType to outputType |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.