Load more w turbo_frame #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palkan
approved these changes
Aug 2, 2023
palkan
left a comment
palkan
left a comment
There was a problem hiding this comment.
Первое решение с настоящей постраничной загрузкой 👏
Да, получается матрёшка, но она позволяет без лишних движений реализовать подгрузку. Нам, кстати, нужна только одна страница (см. демо из задания), так что можно было бы чуть упростить.
Ну и вопрос идеологический — нужно ли тут делать отдельный экшн в контроллере или мы можем эту логику реализовать в #show? Тут можно долго спорить) (но я за второй вариант 🙂)
| <a href="#" class="text-secondary hover:text-primary transition-colors">Load more</a> | ||
| </li> | ||
| <%= turbo_frame_tag "load_more_frame_0", src: load_more_artist_path(artist, page: 0) do %> | ||
| <p>Loading...</p> |
There was a problem hiding this comment.
Для этой страницы с точки зрения UX лучше было бы первую страницу грузить сразу, она на самом видном месте.
| @@ -0,0 +1,10 @@ | |||
| <%= turbo_frame_tag "load_more_frame_#{page}" do %> | |||
There was a problem hiding this comment.
Кажется, тут не хватает target — клик на трек в списке популярных не открывает плеер теперь.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Задание:
Необходимо реализовать подгрузку следующих 5 треков при клике на "Load more" на странице артиста. Использовать Turbo Frames.