Day 1 task #1
Open
Day 1 task #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palkan
approved these changes
Aug 1, 2023
palkan
left a comment
palkan
left a comment
There was a problem hiding this comment.
Как я писал в чате, могут быть проблемы при одновременном использовании data-turbo-permanent и data-turbo-morph-permanent — это как раз наш случай тут. Из-за наличия обычного permanent элемента, morphdom перемонтирует плеер на странице. Починить можно, переписав другие элементы на data-turbo-morph-permanent.
| if (prevEl.hasAttribute('data-turbo-morph-permanent')) { | ||
| return false; | ||
| } | ||
| } |
There was a problem hiding this comment.
Здесь лучше добавить явный return true; сейчас тоже работает (там внутри проверяют === false), но лучше соблюдать интерфейс.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Задание:
Необходимо перенести логику перманентных элементов из Turbo в morphdom и сделать так, чтобы элементы остались в DOM-дереве, если нет необходимости их перерисовывать.
Критерии выполнения
Прогресс-бар плеера не прерывается при навигации по приложению
Прогресс-бар стартует заново при смене трека в плеера
Советы по реализации
Используйте опцию onBeforeElUpdated в параметрах morphdom.
https://github.com/patrick-steele-idem/morphdom