Fix background-state not saved with the preferences switch #509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsdc
force-pushed
the
stsdc/fix-run-in-background-switch
branch
from
6cd3a24 to
cf123ae
Compare
danirabbit
approved these changes
Nov 24, 2025
Member
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
@stsdc Ah I'm not actually sure what this is about. Maybe it was supposed to make sure you couldn't get into a funny state like indicator on, but background off or something. But let's remove it and we can revisit if its a problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #500
@danirabbit I have basically removed your code to make it work again. Do you remember why it was added?