Refactor: use a single buffer reader for all sample playback nodes #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… will allow it to be used by the remaining sample nodes
…ng from a buffer view that has already clamped the range to respect start/stop offsets
steve-mackinnon
force-pushed
the
shared-buffer-reader
branch
from
8ecc677 to
92810ea
Compare
nick-thompson
approved these changes
Jan 9, 2026
Contributor
nick-thompson
left a comment
nick-thompson
left a comment
There was a problem hiding this comment.
This is great, thank you!
|
|
||
| // Note: this is set to 1.1 ms to preserve backwards compatibility. Historically, a gain fade with | ||
| // a step size of 0.02 was used for SampleSeqNode, which comes out to roughly 1.1 ms at 44100 Hz. | ||
| static constexpr double FadeTime = 1.1; |
Contributor
There was a problem hiding this comment.
😅 that certainly wasn't intentional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits out a shared utility called
BufferReaderthat handles the sample reading portion of the various sample nodes, and updates the samples nodes to use it in place of custom implementations.BufferReaderhandles: