fix: be lenient in parsing notarytool output #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were seeing failures in our CI on notarytool
invocations, as warnings emitted by notarytool
were tried to be parsed as JSON.
An example for such a warning is the following:
```
✖ Finalizing package [FAILED: Failed to notarize via notarytool. Failed with unexpected result:
warning: unhandled Platform key FamilyDisplayName
{"id":"4803438f-a484-493a-acfd-1ef504a1e70b","message":"Processing complete","status":"Accepted"}]
```
This makes it so the parsing can work with such
warnings, by finding the valid JSON line in the
output and only using that to parse from.
The less-hacky way to fix this would be to properly
differentiate between stdout and stderr in `spawn.ts`,
but I'm unable to test other commands and didn't
want to break stuff, so I address the issue for
notarytool only here.
Furthermore, this makes the assumption that Apple's
signing servers will only reply with a single JSON
line. This was the case for all my testing queries,
but I'm not sure if this holds true universally.
Still, I think this is much better than the current
situation, which just fails on whatever warning is
emitted by notarytool.
BlackHole1
reviewed
Nov 6, 2025
Co-authored-by: Kevin Cui <github@bugs.cc>
BlackHole1
approved these changes
Nov 7, 2025
msanft
changed the title
Author
|
Fixed the 2 CI failures, feel free to re-run @BlackHole1 |
Author
|
Hmm: |
Signed-off-by: Kevin Cui <bh@bugs.cc>
BlackHole1
requested changes
Nov 12, 2025
| try { | ||
| parsed = JSON.parse(jsonOut); | ||
| } catch (err) { | ||
| throw new Error(`Could not parse notarytool output: \n\n${rawOut}`); |
Member
There was a problem hiding this comment.
Could we as a fallback try parse the entire output as JSON so that anything that worked before due to strange chunking or whatever keeps working.
Super appreciate the test coverage 🙇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were seeing failures in our CI on notarytool
invocations, as warnings emitted by notarytool
were tried to be parsed as JSON.
An example for such a warning is the following:
This makes it so the parsing can work with such
warnings, by finding the valid JSON line in the
output and only using that to parse from.
The less-hacky way to fix this would be to properly
differentiate between stdout and stderr in
spawn.ts,but I'm unable to test other commands and didn't
want to break stuff, so I address the issue for
notarytool only here.
Furthermore, this makes the assumption that Apple's
signing servers will only reply with a single JSON line.
This was the case for all my testing queries, but I'm
not sure if this holds true universally.
Still, I think this is much better than the current situation,
which just fails on whatever warning is emitted by notarytool.