Skip to content
This repository was archived by the owner on Oct 2, 2020. It is now read-only.

Conversation

@alexstrat
Copy link

@alexstrat alexstrat commented Jun 16, 2017

Those 2 fixes worked on my project.

@alexstrat alexstrat changed the title Attempt to fix sass imports Fix sass imports Jun 16, 2017
@alexstrat
Copy link
Author

@paulcbetts @saschagehlich do you think you could review these changes?

@saschagehlich
Copy link
Contributor

Sorry man, I'm not responsible for this repository. :(

@alreece45
Copy link

@alexstrat I'm not a contributor here, the paths fix is simple enough, but the second change doesn't seem as obvious to me. Is the current code removing /sass/ from the path, even when it isn't supposed to?

It may be beneficial to have that as a separate request-- but I'm not responsible for this repository, either.

@Tenrys
Copy link

Tenrys commented May 25, 2018

This should fix nested imports, right?
Trying to load the entirety of bulma gets pretty broken right now, file paths seem broken.
@import "node_modules/bulma/bulma" works, @import "sass/utilities/_all" inside of the file doesn't, seemingly because of resolved path issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants