Add simple completion support for watcher#95
Open
spinscale wants to merge 1 commit intoelastic:masterfrom
Open
Add simple completion support for watcher#95spinscale wants to merge 1 commit intoelastic:masterfrom
spinscale wants to merge 1 commit intoelastic:masterfrom
Conversation
This adds basic completion support for watcher. Some things need to be extended, but it should already help a lot.
Contributor
Author
|
@spalger ping, anything I can help with? Adding this conditionally only when watcher is active? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds basic completion support for watcher. Some things need to be extended,
but it should already help a lot.
Several things are not covered here yet:
es.js, but it might be a good idea to also check the installed plugins and decide based on that what to load. This would be even more useful with all of our open source analyser, repository and discovery plugins.chainstuff are not supported