Skip to content

bk(comment-trigger): support case insensitive#18737

Open
v1v wants to merge 2 commits intoelastic:mainfrom
v1v:feature/support-ignore-case-sensitive
Open

bk(comment-trigger): support case insensitive#18737
v1v wants to merge 2 commits intoelastic:mainfrom
v1v:feature/support-ignore-case-sensitive

Conversation

@v1v
Copy link
Member

@v1v v1v commented Feb 5, 2026

Release notes

[rn:skip]

What does this PR do?

Support GitHub comment triggers with case insensitive format.

Why is it important/What is the impact to the user?

Improve the DX

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@v1v v1v self-assigned this Feb 5, 2026
@v1v v1v added backport-8.19 Automated backport to the 8.19 branch backport-9.3 Automated backport to the 9.3 branch labels Feb 5, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)
  • /run exhaustive tests : Run the exhaustive tests Buildkite pipeline.

steps:
- label: "Trigger logstash-exhaustive-tests-pipeline for PRs with qa/acceptance/ changes"
if: build.pull_request.id != null && build.env("GITHUB_PR_TRIGGER_COMMENT") != "run exhaustive tests"
if: build.pull_request.id != null && build.env("GITHUB_PR_TRIGGER_COMMENT") !~ /(?i)^run\\s+exhaustive\\s+tests/
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewer: https://buildkite.com/docs/pipelines/configure/conditionals#variable-and-syntax-reference-operator-syntax, I assume it uses the standard regex so I can use the pattern case-insensitive

@v1v v1v requested review from a team and donoghuc February 5, 2026 08:55
Copy link
Contributor

@fr4nc1sc0-r4m0n fr4nc1sc0-r4m0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Cas Donoghue <cas.donoghue@gmail.com>
@v1v v1v requested a review from donoghuc February 9, 2026 15:09
@elasticmachine
Copy link

💛 Build succeeded, but was flaky

Failed CI Steps

History

cc @v1v

steps:
- label: "Trigger logstash-exhaustive-tests-pipeline for PRs with qa/acceptance/ changes"
if: build.pull_request.id != null && build.env("GITHUB_PR_TRIGGER_COMMENT") != "run exhaustive tests"
if: build.pull_request.id != null && build.env("GITHUB_PR_TRIGGER_COMMENT") !~ /(?i)^run\\s+exhaustive\\s+tests/

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bot message is

🤖 GitHub comments
Just comment with:

run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)
/run exhaustive tests : Run the exhaustive tests Buildkite pipeline.

Aren't we exluding the / in /run ... by using ^?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can fix the comment instead

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elastic/oblt-actions#452

Let's keep it simple here

Copy link
Member

@donoghuc donoghuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-8.19 Automated backport to the 8.19 branch backport-9.3 Automated backport to the 9.3 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants