fix(bigshot.lic): v5.11.4 new command checks

[mrhoribu]

Important

Update bigshot.lic to v5.11.4 with new command checks and improved follower handling.

• Version Update:
  • Update bigshot.lic to version 5.11.4, requiring Lich >= 5.13.0.
• Command Checks:
  • Add splashy and essence command checks in initialize_command_data.
  • Update @COMMAND_MODIFIER_REGEX and @COMMAND_AMOUNT_CHECKS for new commands.
• Follower Handling:
  • Add unhide command if hidden and leading in multiple follower management functions.
  • Add ATTACK event to follower routine if followers are separated.
• Misc:
  • Remove unnecessary blank lines in Bigshot class.

^{This description was created by for 77b61a0. You can customize this summary. It will automatically update as commits are pushed.}

[mrhoribu]

@ellipsis review again

[mrhoribu]

@ellipsis hide previous comments and review again

[ellipsis-dev]

Caution

Changes requested ❌

Reviewed everything up to 77b61a0 in 2 minutes and 16 seconds. Click for details.

• Reviewed 175 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 9 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. scripts/bigshot.lic:8

• Draft comment:
  Version header updated to v5.11.4 with required Lich bumped to 5.13.0. Confirm this upgrade is intentional.
• Reason this comment was not posted:
  Comment looked like it was already resolved.

2. scripts/bigshot.lic:17

• Draft comment:
  Changelog entries for v5.11.4 have been added. Ensure the changelog remains comprehensive and clear.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is asking the PR author to ensure that the changelog is comprehensive and clear, which is a general request for confirmation and not a specific code suggestion or issue. It violates the rule against asking the author to ensure something is done.

3. scripts/bigshot.lic:2565

• Draft comment:
  The command modifier regex has been updated to include 'essence' and 'splashy'. Verify that tests cover these new modifiers.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

4. scripts/bigshot.lic:2570

• Draft comment:
  New command amount checks for 'essence' (and its negation) are added using Resources.shadow_essence. Ensure that Resources.shadow_essence is properly defined and behaves as expected.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to ensure that Resources.shadow_essence is properly defined and behaves as expected. This falls under the category of asking the author to double-check things, which is against the rules.

5. scripts/bigshot.lic:3575

• Draft comment:
  Added 'splashy' and '!splashy' room checks using Room.current.tags. Confirm that Room.current.tags reliably returns an array with the 'meta:splashy' tag.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

6. scripts/bigshot.lic:5896

• Draft comment:
  Multiple fput('unhide') calls are now inserted in various follower-check blocks. Consider refactoring these repeated calls into a helper function to improve maintainability and consistency.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

7. scripts/bigshot.lic:6355

• Draft comment:
  An ATTACK event (:ATTACK) is added when followers are missing. Ensure that the event is handled correctly elsewhere and that its timing is appropriate.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

8. scripts/bigshot.lic:7825

• Draft comment:
  A final fput('unhide') call is added in the head/lead block. Verify that automatically unhiding in this context does not interfere with other visibility or command logic.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

9. scripts/bigshot.lic:5908

• Draft comment:
  Typographical note: The message string contains four consecutive periods (Waiting for followers....). If an ellipsis was intended, consider using three periods (...) instead.
• Reason this comment was not posted:
  Comment was on unchanged code.

Workflow ID: wflow_d34nb3ywwRApbHkx

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}