Skip to content

squid:S1151 - switch case clauses should not have too many lines #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
georgekankava wants to merge 1 commit into
base: master
Choose a base branch
from
Open

squid:S1151 - switch case clauses should not have too many lines #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions app/src/main/java/com/einmalfel/podlisten/MainActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,15 +412,7 @@ public synchronized void onClick(View v) {
PodlistenAccount.getInstance().refresh(0);
break;
case SORT:
Preferences preferences = Preferences.getInstance();
Preferences.SortingMode newMode = preferences.getSortingMode().nextCyclic();
preferences.setSortingMode(newMode);
if (playlistFragment != null) {
playlistFragment.reloadList();
} else {
Log.w(TAG, "Playlist fragment doesn't exist yet, skipping reload");
}
snackbarController.showSnackbar(newMode.toString(), Snackbar.LENGTH_SHORT, null, null);
currentFabActionSortCase();
break;
default:
Log.e(TAG, "Unexpected currentFabAction received: " + currentFabAction);
Expand All @@ -445,6 +437,18 @@ public synchronized void onClick(View v) {
}
}

private void currentFabActionSortCase() {
Preferences preferences = Preferences.getInstance();
Preferences.SortingMode newMode = preferences.getSortingMode().nextCyclic();
preferences.setSortingMode(newMode);
if (playlistFragment != null) {
playlistFragment.reloadList();
} else {
Log.w(TAG, "Playlist fragment doesn't exist yet, skipping reload");
}
snackbarController.showSnackbar(newMode.toString(), Snackbar.LENGTH_SHORT, null, null);
}

@Override
protected void onNewIntent(Intent intent) {
super.onNewIntent(intent);
Expand Down
64 changes: 40 additions & 24 deletions app/src/main/java/com/einmalfel/podlisten/PlayerService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,22 +117,10 @@ public void run() {
synchronized (service) {
switch (ct) {
case STATE:
if (lastState != service.getState() || lastEpisode != currentId) {
sendStateUpdate();
lastState = service.state;
lastEpisode = currentId;
}
ctStateCase();
break;
case PROGRESS:
if (lastLength != service.length || lastProgress != service.getProgress()) {
sendProgressUpdate();
lastLength = service.length;
lastProgress = service.progress;
}
if (fixingEndingSkip && service.length - service.progress < TRACK_ENDING_THRESHOLD_MS) {
Log.i(TAG, "Fixing ending skip: calling onCompletion, pos: " + service.progress);
onCompletion(player);
}
ctProgressCase();
break;
default:
Log.e(TAG, "Unexpected ct received: " + ct);
Expand All @@ -143,6 +131,26 @@ public void run() {
Log.d(TAG, "Finishing callback thread");
}

private void ctProgressCase() {
if (lastLength != service.length || lastProgress != service.getProgress()) {
sendProgressUpdate();
lastLength = service.length;
lastProgress = service.progress;
}
if (fixingEndingSkip && service.length - service.progress < TRACK_ENDING_THRESHOLD_MS) {
Log.i(TAG, "Fixing ending skip: calling onCompletion, pos: " + service.progress);
onCompletion(player);
}
}

private void ctStateCase() {
if (lastState != service.getState() || lastEpisode != currentId) {
sendStateUpdate();
lastState = service.state;
lastEpisode = currentId;
}
}

private void sendStateUpdate() {
Log.d(TAG, "Sending new playback state " + service.getState() + " id " + currentId);
for (PlayerStateListener listener : listeners) {
Expand Down Expand Up @@ -367,11 +375,7 @@ public synchronized void onAudioFocusChange(int focusChange) {
Log.i(TAG, "Audio focus chagned from " + focusMode + " to " + focusChange);
switch (focusChange) {
case AudioManager.AUDIOFOCUS_GAIN:
if (focusMode == AudioManager.AUDIOFOCUS_LOSS_TRANSIENT_CAN_DUCK) {
setVolume(1f);
} else if (focusMode == AudioManager.AUDIOFOCUS_LOSS_TRANSIENT && state == State.PLAYING) {
resume();
}
focusChangeAudioFocusGainCase();
break;
case AudioManager.AUDIOFOCUS_LOSS:
stop();
Expand All @@ -388,6 +392,14 @@ public synchronized void onAudioFocusChange(int focusChange) {
focusMode = focusChange;
}

private void focusChangeAudioFocusGainCase() {
if (focusMode == AudioManager.AUDIOFOCUS_LOSS_TRANSIENT_CAN_DUCK) {
setVolume(1f);
} else if (focusMode == AudioManager.AUDIOFOCUS_LOSS_TRANSIENT && state == State.PLAYING) {
resume();
}
}

public synchronized void addListener(PlayerStateListener listener) {
callbackThread.addListener(listener);
}
Expand Down Expand Up @@ -676,11 +688,7 @@ public synchronized void playPauseResume() {
case STOPPED:
case STOPPED_ERROR:
case STOPPED_EMPTY:
if (currentId != 0) {
playEpisode(currentId);
} else {
playNext();
}
stateStoppedEmptyCase();
break;
case PLAYING:
pause();
Expand All @@ -694,6 +702,14 @@ public synchronized void playPauseResume() {
}
}

private void stateStoppedEmptyCase() {
if (currentId != 0) {
playEpisode(currentId);
} else {
playNext();
}
}

private void initPlayer() {
if (player == null) {
player = new MediaPlayer();
Expand Down
160 changes: 92 additions & 68 deletions app/src/main/java/com/einmalfel/podlisten/Preferences.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,12 +322,7 @@ private synchronized void readPreference(Key key) {
completeAction = readEnum(Key.COMPLETE_ACTION, DEFAULT_COMPLETE_ACTION);
break;
case DOWNLOAD_NETWORK:
DownloadNetwork newDLNetwork = readEnum(Key.DOWNLOAD_NETWORK, DEFAULT_DOWNLOAD_NETWORK);
if (downloadNetwork != newDLNetwork) {
downloadNetwork = newDLNetwork;
DownloadReceiver.stopDownloads(null);
context.sendBroadcast(new Intent(DownloadReceiver.UPDATE_QUEUE_ACTION));
}
keyDownloadNetworkCase();
break;
case PAUSE_ON_DISCONNECT:
pauseOnDisconnect = sPrefs.getBoolean(Key.PAUSE_ON_DISCONNECT.toString(), true);
Expand All @@ -336,15 +331,7 @@ private synchronized void readPreference(Key key) {
fixSkipEnding = sPrefs.getBoolean(Key.FIX_SKIP_ENDING.toString(), false);
break;
case AUTO_DOWNLOAD_AC:
boolean newAutoDownloadAC = sPrefs.getBoolean(Key.AUTO_DOWNLOAD_AC.toString(), false);
if (newAutoDownloadAC != autoDownloadACOnly) {
autoDownloadACOnly = newAutoDownloadAC;
if (!autoDownloadACOnly) {
context.sendBroadcast(new Intent(DownloadReceiver.UPDATE_QUEUE_ACTION));
} else if (!DownloadReceiver.isDeviceCharging()) {
DownloadReceiver.stopDownloads(null);
}
}
keyAutoDownloadAcCase();
break;
case PLAYER_FOREGROUND:
playerForeground = sPrefs.getBoolean(Key.PLAYER_FOREGROUND.toString(), false);
Expand All @@ -354,75 +341,112 @@ private synchronized void readPreference(Key key) {
Log.e(TAG, "read " + currentActivity);
break;
case AUTO_DOWNLOAD:
AutoDownloadMode newM = readEnum(Key.AUTO_DOWNLOAD, DEFAULT_DOWNLOAD_MODE);
if (newM != autoDownloadMode) {
if (newM == AutoDownloadMode.PLAYLIST && autoDownloadMode == AutoDownloadMode.ALL_NEW) {
DownloadReceiver.stopDownloads(
Provider.K_ESTATE + " != " + Provider.ESTATE_IN_PLAYLIST);
} else if (newM == AutoDownloadMode.NEVER) {
DownloadReceiver.stopDownloads(null);
}
autoDownloadMode = newM;
context.sendBroadcast(new Intent(DownloadReceiver.UPDATE_QUEUE_ACTION));
}
keyAutoDownloadCase();
break;
case SORTING_MODE:
sortingMode = readEnum(Key.SORTING_MODE, DEFAULT_SORTING_MODE);
break;
case MAX_DOWNLOADS:
MaxDownloadsOption newMaxDL = readEnum(Key.MAX_DOWNLOADS, DEFAULT_MAX_DOWNLOADS);
if (newMaxDL != maxDownloads) {
maxDownloads = newMaxDL;
context.sendBroadcast(new Intent(DownloadReceiver.UPDATE_QUEUE_ACTION));
}
keyMaxDownloadsCase();
break;
case REFRESH_INTERVAL:
RefreshIntervalOption newRI = readEnum(Key.REFRESH_INTERVAL, DEFAULT_REFRESH_INTERVAL);
if (newRI != refreshInterval) {
refreshInterval = newRI;
PodlistenAccount.getInstance().setupSync(refreshInterval.periodSeconds);
}
keyRefreshIntervalCase();
break;
case STORAGE_PATH:
String storagePreferenceString = sPrefs.getString(Key.STORAGE_PATH.toString(), "");
if (storagePreferenceString.isEmpty()) {
// by default, if there are removable storages use first removable, otherwise use last one
List<Storage> storages = Storage.getWritableStorages();
storage = Storage.getPrimaryStorage();
for (Storage storageOption : storages) {
storage = storageOption;
if (storageOption.isRemovable()) {
break;
}
}
try {
storage.createSubdirs();
sPrefs.edit().putString(Key.STORAGE_PATH.toString(), storage.toString()).commit();
} catch (IOException exception) {
Log.wtf(TAG, "Failed to init storage known to be writable " + storage, exception);
}
} else {
try {
Storage newStorage = new Storage(new File(storagePreferenceString));
newStorage.createSubdirs();
if (storage != null && !storage.equals(newStorage)) {
clearStorage();
}
storage = newStorage;
} catch (IOException e) {
Log.wtf(
TAG, "Failed to set storage " + storagePreferenceString + ". Reverting to prev", e);
sPrefs.edit().putString(
Key.STORAGE_PATH.toString(), storage == null ? "" : storage.toString()).commit();
}
}
keyStoragePathCase();
break;
default:
Log.e(TAG, "Unexpected key received: " + key);
break;
}
}

private void keyStoragePathCase() {
String storagePreferenceString = sPrefs.getString(Key.STORAGE_PATH.toString(), "");
if (storagePreferenceString.isEmpty()) {
// by default, if there are removable storages use first removable, otherwise use last one
List<Storage> storages = Storage.getWritableStorages();
storage = Storage.getPrimaryStorage();
for (Storage storageOption : storages) {
storage = storageOption;
if (storageOption.isRemovable()) {
break;
}
}
try {
storage.createSubdirs();
sPrefs.edit().putString(Key.STORAGE_PATH.toString(), storage.toString()).commit();
} catch (IOException exception) {
Log.wtf(TAG, "Failed to init storage known to be writable " + storage, exception);
}
} else {
try {
Storage newStorage = new Storage(new File(storagePreferenceString));
newStorage.createSubdirs();
if (storage != null && !storage.equals(newStorage)) {
clearStorage();
}
storage = newStorage;
} catch (IOException e) {
Log.wtf(
TAG, "Failed to set storage " + storagePreferenceString + ". Reverting to prev", e);
sPrefs.edit().putString(
Key.STORAGE_PATH.toString(), storage == null ? "" : storage.toString()).commit();
}
}
}

private void keyRefreshIntervalCase() {
RefreshIntervalOption newRI = readEnum(Key.REFRESH_INTERVAL, DEFAULT_REFRESH_INTERVAL);
if (newRI != refreshInterval) {
refreshInterval = newRI;
PodlistenAccount.getInstance().setupSync(refreshInterval.periodSeconds);
}
}

private void keyMaxDownloadsCase() {
MaxDownloadsOption newMaxDL = readEnum(Key.MAX_DOWNLOADS, DEFAULT_MAX_DOWNLOADS);
if (newMaxDL != maxDownloads) {
maxDownloads = newMaxDL;
context.sendBroadcast(new Intent(DownloadReceiver.UPDATE_QUEUE_ACTION));
}
}

private void keyAutoDownloadCase() {
AutoDownloadMode newM = readEnum(Key.AUTO_DOWNLOAD, DEFAULT_DOWNLOAD_MODE);
if (newM != autoDownloadMode) {
if (newM == AutoDownloadMode.PLAYLIST && autoDownloadMode == AutoDownloadMode.ALL_NEW) {
DownloadReceiver.stopDownloads(
Provider.K_ESTATE + " != " + Provider.ESTATE_IN_PLAYLIST);
} else if (newM == AutoDownloadMode.NEVER) {
DownloadReceiver.stopDownloads(null);
}
autoDownloadMode = newM;
context.sendBroadcast(new Intent(DownloadReceiver.UPDATE_QUEUE_ACTION));
}
}

private void keyAutoDownloadAcCase() {
boolean newAutoDownloadAC = sPrefs.getBoolean(Key.AUTO_DOWNLOAD_AC.toString(), false);
if (newAutoDownloadAC != autoDownloadACOnly) {
autoDownloadACOnly = newAutoDownloadAC;
if (!autoDownloadACOnly) {
context.sendBroadcast(new Intent(DownloadReceiver.UPDATE_QUEUE_ACTION));
} else if (!DownloadReceiver.isDeviceCharging()) {
DownloadReceiver.stopDownloads(null);
}
}
}

private void keyDownloadNetworkCase() {
DownloadNetwork newDLNetwork = readEnum(Key.DOWNLOAD_NETWORK, DEFAULT_DOWNLOAD_NETWORK);
if (downloadNetwork != newDLNetwork) {
downloadNetwork = newDLNetwork;
DownloadReceiver.stopDownloads(null);
context.sendBroadcast(new Intent(DownloadReceiver.UPDATE_QUEUE_ACTION));
}
}

@NonNull
public RefreshIntervalOption getRefreshInterval() {
return refreshInterval;
Expand Down
Loading