-
Notifications
You must be signed in to change notification settings - Fork 78
4 new features #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
abdennour
wants to merge
19
commits into
ehpc:master
Choose a base branch
from
abdennour:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
4 new features #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rectify message function. - Add animate function - Add stopAnimate function
if array , rectify loop
- you can pass "timer" && "timeout" as global settings , the "animate" function will reuse them if you don't specify argument 2 AND/OR argument 3 - you can call ```animate ``` function without argument , then, the animated message will be the message set on calling on ```show``` function .
- calling ``` stopAnimate``` without argument means --> stop the last running job .
- bug if no argument -> get the current message and animate it
Calling with : - One Argument --> "percentOrCurrent" is the percent of progress - Two Argument ---> "percentOrCurrent" is the current amount, "total" is the total amount .
use js not jquery to get the current width
use js not jquery to get the current width
Since our language is arabic , rtl=true is default .
If you want LTR ,
```js
waitingDialog.show('waiting..',{rtl:false})
```
Owner
|
Hey, abdennour! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
message, animate/stopAnimate and progress are 4 features have been added in this branch.
Plz, review then merge if it is approved.