message, animate, stopAnimate functions #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rectify message function : add setting as shared variable
- animate function :
```
waitingDialog.show('go') // display "go"
waitingDialog.animate('go') // display "go .." then , "go...." , then "go......" ., then repeat the loop
waitingDialog.animate(["w","y"","z"]) //display "w" then "y" then "z" ,then repeat the loop
waitingDialog.animate(function(container){
container.html(new Date());
})
```
Owner
|
Hey, abdennour! I've added your two last pull requests to a milestone https://github.com/ehpc/bootstrap-waitingfor/milestones so I could fix it and test it later, alternatively you could follow cotributing guidelines in README and make a proper pull request which will pass all required tests so I could accept it easily. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rectify message function : add setting as shared variable
animate function :