Relax required_ruby_version to support Ruby 4.0#312
Relax required_ruby_version to support Ruby 4.0#312PikachuEXE merged 1 commit intoegonSchiele:masterfrom
required_ruby_version to support Ruby 4.0#312Conversation
PikachuEXE
left a comment
There was a problem hiding this comment.
Also .github/workflows/tests.yaml should be updated to add 4.0 (it should pick up beta?)
Add Ruby 4.0 to CI Matrix Co-authored-by: PikachuEXE <git@pikachuexe.net>
31759a8 to
b88e79c
Compare
|
@PikachuEXE I have updated However, |
The CI was failing because the aruba gem dependency includes a https://github.com/taketo1113/contracts.ruby/actions/runs/19799663868/job/56725105155#step:3:49 archive-tar-minitar (0.12)
minitar (~> 0.12)
minitar-cli (~> 0.12)
# when use ruby 4.0-preview2: test fail
+ aruba (0.14.14)
+ childprocess (>= 0.6.3, < 4.0.0)
+ contracts (~> 0.9)
+ cucumber (>= 1.3.19)
+ ffi (~> 1.9)
+ rspec-expectations (>= 2.99)
+ thor (>= 0.19, < 2.0)
# use ruby 3.4.7: test pass
- aruba (2.3.2)
- bundler (>= 1.17, < 3.0)
- contracts (>= 0.16.0, < 0.18.0)
- cucumber (>= 8.0, < 11.0)
- rspec-expectations (>= 3.4, < 5.0)
- thor (~> 1.0)
ast (2.4.3) |
|
Thx for checking |
|
Since aruba gem v2.3.3 has been released, I believe the CI should now pass. |
|
Oh I am not an owner |
|
Thank you for merging it! |
|
pushed thanks all |
|
Added missing tag v0.17.3 |
|
Fun I always forget |
|
I usually use SourceTree with option to push |
This Pull Request relaxed the
required_ruby_versionto allow Ruby 4.0.The current gemspec specifies an upper bound of
< 4, which preventsgem install contractsfrom working on Ruby 4.0, scheduled for release on December 25.By removing this upper bound, the gem will continue to work on Ruby 4.0 and future Ruby versions.
Additional Information
All tests pass on my local environment using Ruby 4.0-dev.