Reorganisation of Controls to remove overlap and allow for smoother w…

MinecraftBdsManager/Configuration/Settings.cs

@@ -58,7 +58,11 @@ public static Settings CurrentSettings
                 return _instance;
             }
         }
-
+        ///<summary>
+        /// The settings file that was loaded with this instance
+        ///</summary>
+        public static String SettingsLocation { get; } = _settingsFilePath;
+
         /// <summary>
         /// Settings that govern if and how logs will be written to the file system.
         /// </summary>

MinecraftBdsManager/Managers/BdsManager.cs

@@ -84,9 +84,9 @@ private set
         public static DateTime? UserLastLoggedOffAt { get; private set; }
 
         /// <summary>
-        /// Path to the world directory.  This is null if the server has not been started.
+        /// Path to the world directory.  This is an empty path if the server has never been started to avoid Path.combine errors on startup. (race condition)
         /// </summary>
-        public static string? WorldDirectoryPath { get; private set; }
+        public static string? WorldDirectoryPath { get; private set; } = "";
 
         /// <summary>
         /// Determines if users have active on the server in the last time interval specified

MinecraftBdsManager/Managers/ProcessManager.cs

@@ -60,7 +60,7 @@ public static bool StartProcess(ProcessName processName, string executablePath,
                 return StartFireAndForgetProcess(executablePath, arguments);
             }
 
-            Trace.TraceInformation($"Starting process {processName}.");
+            Trace.TraceInformation($"Starting process: {processName}, using {arguments}.");
 
             // Check to see if we are already tracking this process...
             if (TrackedProcesses.ContainsKey(processName) && processName != ProcessName.FireAndForget)

MinecraftBdsManager/frmMain.cs

@@ -19,9 +19,11 @@ private async void btnIssueCommand_Click(object sender, EventArgs e)
             {
                 return;
             }
-
-            await BdsManager.SendCommandAsync(txtCustomCommand.Text, userSentCommand: true);
-            txtCustomCommand.Text = String.Empty;
+            if (BdsManager.ServerIsRunning) 
+            {
+                await BdsManager.SendCommandAsync(txtCustomCommand.Text, userSentCommand: true);
+                txtCustomCommand.Text = String.Empty;
+            }
         }
 
         private void frmMain_FormClosing(object sender, FormClosingEventArgs e)
@@ -142,5 +144,16 @@ private void toolBtnViewLog_Click(object sender, EventArgs e)
 
             ProcessManager.StartProcess(ProcessName.FireAndForget, "explorer.exe", LogManager.CurrentLogFilePath);
         }
+
+        private void toolBtnSettings_Click(object sender, EventArgs e)
+        {
+            if (string.IsNullOrWhiteSpace(Settings.SettingsLocation))
+            {
+                LogManager.LogWarning($"An invalid Settings location has been specified {Settings.SettingsLocation}");
+                return;
+            }
+
+            ProcessManager.StartProcess(ProcessName.FireAndForget, "explorer.exe", Settings.SettingsLocation);
+        }
     }
 }