Fix Refresh on load functionality - Add Pull to Refresh #41
Open
Biztactix-Ryan wants to merge 4 commits intoeftpmc:masterfrom
Open
Fix Refresh on load functionality - Add Pull to Refresh #41Biztactix-Ryan wants to merge 4 commits intoeftpmc:masterfrom
Biztactix-Ryan wants to merge 4 commits intoeftpmc:masterfrom
Conversation
* Add refetchOnMount to usePlaylist, useAlbum, and useExternalAlbum hooks * Add refetchOnMount to useArtist and useExternalArtist hooks * Add pull-to-refresh functionality to playlist, album, and artist detail views * Fix pull-to-refresh using FlashList native props instead of RefreshControl
Owner
RPReplay_Final1769499578.mp4Remounting? |
eftpmc
requested changes
Jan 27, 2026
Owner
eftpmc
left a comment
There was a problem hiding this comment.
Fix visual glitch, refetch list content only?
Contributor
Author
|
I'll see what I can do, Don't have iOS to test on, Looks fine on my device and emulator... |
Owner
|
I would recommend looking at the Flashlist for the respective screen |
* explore refactor * explore * dump * explore stage 1 * external artist view * 1.1.6 * scrobbling and navfix * android build * ios build * fixes mediaimage playing screen * 1.1.7 android * ios 1.1.7 --------- Co-authored-by: SaturnEFTPMC <zackhhi@gmail.com> Co-authored-by: ari <61393419+eftpmc@users.noreply.github.com>
* explore refactor * explore * dump * explore stage 1 * external artist view * 1.1.6 * scrobbling and navfix * android build * ios build * fixes mediaimage playing screen * 1.1.7 android * ios 1.1.7 --------- Co-authored-by: SaturnEFTPMC <zackhhi@gmail.com> Co-authored-by: ari <61393419+eftpmc@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the Offline first did make the app usable in spotty internet, but if it does manage to load a blank playlist or album, it won't refresh automatically when connected again, so I added a background refresh on Load of screen, and pull to refresh for Albums, Playlists and Artists...