Fastboot rehydration #66
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is expanding on the work done in ember-fastboot/ember-cli-fastboot#818 that is intending to allow people to set a config in their app config to enable rehydration instead of needing to use the
EXPERIMENTAL_RENDER_MODE_SERIALIZEenvironmental variable.This is intended to allow people to create a PR to a site and test that with a preview app before committing, mainly because depending on your deployment it might be a bit difficult to enable a single environment variable for a "branch" as a test.
The upstream fastboot API for this hasn't been finalised (you can see some discussion of the API in the PR thread). Also this PR is only likely going to useful as a visual reference for the proposed change because the service I'm using to install a monorepo package ( https://gitpkg.now.sh/ ) doesn't seem to be working for the fastboot package 🙈 I have filed an issue with the project and have a workaround running locally that has allowed me to test that this works, but I think that workaround is overkill for anyone wanting to try this to see it working