Bug fix no grid-symmetry

[eelcovv]

bug fix

Summary by Sourcery

Fix grid_symmetry support in _prepare_capytaine_body by removing the redundant conversion of ReflectionSymmetricMesh to a full mesh and ensure the final mesh extraction works correctly for symmetric meshes; add a unit test to verify the symmetric wrapping and FloatingBody usage.

Bug Fixes:

• Remove forced conversion of ReflectionSymmetricMesh to a full mesh before extracting vertices and faces
• Ensure keep_immersed_part correctly preserves symmetric meshes for final extraction

Tests:

• Add test verifying that grid_symmetry wraps the mesh with ReflectionSymmetricMesh and passes it to FloatingBody

[sourcery-ai]

Reviewer's Guide

This PR ensures the grid_symmetry flag correctly wraps meshes in ReflectionSymmetricMesh without redundant conversions and adds a dedicated test for this behavior.

Class diagram for ReflectionSymmetricMesh handling in engine.py

classDiagram
    class Boat {
        +mesh
        +add_all_rigid_body_dofs()
        +keep_immersed_part()
    }
    class ReflectionSymmetricMesh {
        +vertices
        +faces
        +to_mesh()
    }
    class Trimesh {
        +vertices
        +faces
    }
    Boat --> ReflectionSymmetricMesh : mesh (optional)
    Boat --> Trimesh : mesh conversion
    ReflectionSymmetricMesh --> Trimesh : to_mesh() (removed conversion)

Loading

File-Level Changes

Change	Details	Files
Added test for grid_symmetry behavior	Introduced test_prepare_capytaine_body_with_symmetry to verify symmetric mesh handling Mocked tempfile.mkstemp and cpt.load_mesh to simulate mesh creation Asserted ReflectionSymmetricMesh and FloatingBody are called with the correct arguments	tests/test_engine.py
Removed redundant symmetric mesh conversion in engine	Deleted conditional block that converted ReflectionSymmetricMesh back to full mesh Updated comment to reflect that keep_immersed_part yields correct mesh for both cases	src/fleetmaster/core/engine.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}