e2e: add kds-pcs-downtime test #1999
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burgerdev
reviewed
Jan 5, 2026
| defer setCancel() | ||
| err = ct.RunSet(setCtx) | ||
| t.Logf("Set error: %v", err) | ||
| require.Error(err) |
Member
There was a problem hiding this comment.
I think we should be more specific about the error we're expecting here (same for TDX).
Contributor
Author
There was a problem hiding this comment.
Since this is just a context deadline exceeded error, it is not very meaningful, but I think checking both for context deadline exceeded and if the connection was proxied as suggested below, this should be good.
davidweisse
force-pushed
the
dav/kds-pcs-downtime
branch
from
aa8a1ed to
20334cd
Compare
davidweisse
force-pushed
the
dav/kds-pcs-downtime
branch
from
20334cd to
ced2f23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This E2E test tests the different scenarios for when the KDS/PCS is unavailable, documented in the dev-docs. We can block the KDS/PCS connection from the CLI by setting up an HTTPS proxy and blocking specific domains. To simulate unavailability on the issuer side (i.e., Coordinator), we override the
/etc/hostsfile with, e.g.,127.0.0.1 kdsintf.amd.com. Simulating PCS unavailability for the issuer side is not possible, since all the interaction with the PCS/PCCS happens on the host side, not in the Go code. So for TDX, we only test PCS unavailability on the CLI side.All the tests currently only test CLI <-> Coordinator connections. In the future, we may also want to test Coordinator <-> Initializer connections, where the Coordinator acts as the client.
SNP run: https://github.com/edgelesssys/contrast/actions/runs/19864351537/job/56922742153
TDX run: https://github.com/edgelesssys/contrast/actions/runs/19864358538/job/56922766667