This repository was archived by the owner on Aug 15, 2025. It is now read-only.
Remove redundant new_preconnection constructor #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 28, 2025 21:28
- Added pre-commit hook that runs cargo fmt --check - Created setup scripts for both Unix and Windows platforms - Updated README with instructions for setting up git hooks - Ensures all code is properly formatted before commits Developers can set up hooks by running setup-hooks.sh (Unix) or setup-hooks.bat (Windows)
- Removed the redundant new_preconnection() free function - Updated all tests to use Preconnection::new() directly - This simplifies the API by having only one way to create a Preconnection The free function was completely redundant as it just forwarded to Preconnection::new() without any additional logic or value.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the redundant
new_preconnection()free function that was just forwarding toPreconnection::new()without any additional logic. Updated all 100+ test occurrences to directly usePreconnection::new()instead. This simplifies the API by providing only one way to create a Preconnection instance. All tests continue to pass without any issues.🤖 Generated with Claude Code