add Quick start instructions and generalize $HOME path#6
Open
asashnov wants to merge 2 commits intoedenhill:masterfrom
Open
add Quick start instructions and generalize $HOME path#6asashnov wants to merge 2 commits intoedenhill:masterfrom
asashnov wants to merge 2 commits intoedenhill:masterfrom
Conversation
edenhill
requested changes
Apr 16, 2019
tests/usecase.py
Outdated
| broker2 = KafkaBrokerApp(cluster, conf, kafka_path='/home/maglun/src/kafka') | ||
| broker3 = KafkaBrokerApp(cluster, conf, kafka_path='/home/maglun/src/kafka') | ||
| # Multiple Kafka brokers | ||
| conf = {'version': '2.2.0', 'replication_factor': 3, 'num_partitions': 4, 'kafka_path': kafka_dir} |
Owner
There was a problem hiding this comment.
With version specified (binary download) we dont need kafka_path (source tree), right?
Owner
|
Can you fix the conflicts? |
edenhill
requested changes
Oct 18, 2022
|
|
||
| # Directory for cloning Apache Kafka sources to. | ||
| # It will only be used if 'version' is not specified. | ||
| # Otherwise Apache Kafka binary distrubution will be downloaded to |
Owner
There was a problem hiding this comment.
Suggested change
| # Otherwise Apache Kafka binary distrubution will be downloaded to | |
| # Otherwise Apache Kafka binary distribution will be downloaded to |
| broker2 = KafkaBrokerApp(cluster, conf, kafka_path='/home/maglun/src/kafka') | ||
| broker3 = KafkaBrokerApp(cluster, conf, kafka_path='/home/maglun/src/kafka') | ||
| # Multiple Kafka brokers | ||
| conf = {'version': '2.2.0', 'replication_factor': 3, 'num_partitions': 4} |
Owner
There was a problem hiding this comment.
Let's use 3.3.1, 2.2.0 is quite old now
|
|
||
| # One ZK | ||
| zk1 = ZookeeperApp(cluster, bin_path='/home/maglun/src/kafka/bin/zookeeper-server-start.sh') | ||
| zk1 = ZookeeperApp(cluster, bin_path=os.path.join(kafka_dir, '/bin/zookeeper-server-start.sh')) |
Owner
There was a problem hiding this comment.
I think we can safely remove bin_path here too.
in fact, I don't think the use-case needs to show off local source dir at all, so you can remove kafka_dir up top too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With these changes, I'm able to start my cluster.
Previously there was an error about the unknown argument 'kafka_path' in KafkaBrokerApp constructor.
The only thing I changed: by default, it will start with Kafka broker 2.2.0 (binary distribution) instead of cloning and building Kafka sources. I hope it will not disrupt the way you are used to working with this testing framework. But on the other hand, it will help new users start quickly.