Gestion/Envoie des coordonnées depuis le serveur#144
Open
rthoreau wants to merge 3 commits intoecvdbdx:masterfrom
Open
Gestion/Envoie des coordonnées depuis le serveur#144rthoreau wants to merge 3 commits intoecvdbdx:masterfrom
rthoreau wants to merge 3 commits intoecvdbdx:masterfrom
Conversation
Contributor
rthoreau
commented
Jan 12, 2017
rthoreau
commented
- Création d'un ID lorsque l'utilisateur se connecte
- Envoie des coordonnées depuis le serveur
- Reception côté client des positions des snakes et apples (il manque la création des nouveaux serpents et le dessin sur le canvas)
DavidBruant
requested changes
Jan 13, 2017
Contributor
DavidBruant
left a comment
DavidBruant
left a comment
There was a problem hiding this comment.
You'll need an ESLint run as well
| this.checkCollisionWithApples(); | ||
| // END TEMP | ||
| }, constant.DELAY); | ||
| render(snakes, apples){ |
Contributor
There was a problem hiding this comment.
I believe the board already has the snakes and apples as property. It shouldn't need them as arguments
| }else{ | ||
| console.log('màj'); | ||
| snake.x = laonsaitpas.x; | ||
| snake.y = laonsaitpas.y; // trouver l'ordre à faire, pour créer les serpents non existant, et màj les serpents déjà dans board.snake |
| serverObject.emit('joinGame', apples); | ||
| }); | ||
|
|
||
| socket.on('sendPositions', function(snakes, apples) { |
Contributor
There was a problem hiding this comment.
Don't use a verb to name an event
|
|
||
| socket.on('snakeNew', name => { | ||
|
|
||
| var id = identifier(constant.ID_SIZE); |
Contributor
There was a problem hiding this comment.
Probably a case where you don't need a constant and it can just be hardcoded
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.