Open
Conversation
…test command to use npx for better compatibility. Skips CLI tests that are no longer relevant.
…r-placeImg Removes PlaceImg provider and updates related documentation. Changes test command to use npx for better compatibility. Skips CLI tests that are no longer relevant.
…ow-redirects to 1.15.9, chai to 3.5.0, execa to 5.1.1, and mocha to 11.1.0 for improved compatibility and performance.
…ncies Updates dependencies in package.json
…tions for improved readability and consistency. Promisifies file handling in the download function for better error management. Updates image provider methods to use concise syntax. Implements async/await for download execution to enhance flow control.
Refactors commanderConfig and index files to use const and arrow functions for improved readability and consistency. Promisifies file handling in the download function for better error management. Updates image provider methods to use concise syntax. Implements async/await for download execution to enhance flow control.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request involves several changes to the
spaceholderproject, including the removal of the PlaceImg provider, refactoring to use modern JavaScript syntax, and updates to dependencies and tests.Removal of PlaceImg provider:
README.md: Removed references to PlaceImg as an image provider. [1] [2]image/Image.js: Removed the PlaceImg provider from the list of image providers.image/providers/PlaceImg.js: Deleted the PlaceImg provider module.package.json: Removed PlaceImg from the keywords.test/Factory.js: Removed tests related to the PlaceImg provider.Refactoring to use modern JavaScript syntax:
commanderConfig.js: Updated to useconstand arrow functions. [1] [2]image/Image.js,image/providers/DummyImage.js,image/providers/FakeImg.js,image/providers/LoremPicsum.js: Updated to useconstand modern method definitions. [1] [2] [3] [4]index.js: Refactored to useconst,let, and async/await for better readability and error handling.Dependency updates:
package.json: Updated dependencies and devDependencies to newer versions.Test updates:
test/Cli.js,test/Link.js,test/ProvidersCLI.js: Skipped CLI and symlink tests as they are not essential for verifying the removal of PlaceImg. [1] [2] [3] [4] [5] [6]Other changes:
package.json: Updated the test script to usenpxfor running Mocha.