Skip to content

Conversation

@jinmannwong
Copy link
Contributor

Description

Add defaults to attributes.Mirror, enforcing a default lower limit on polling time and also add attribute to Task.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@jinmannwong
Copy link
Contributor Author

Thanks for the review @colonesej. I don't have permission to merge this PR so could you please do it?

@colonesej
Copy link
Contributor

It seems I can't either @jinmannwong . @corentincarton probably can.

@corentincarton corentincarton merged commit a91fea5 into develop Jan 22, 2026
7 checks passed
@corentincarton corentincarton deleted the improv/mirror branch January 22, 2026 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants