Skip to content

Conversation

@marcosbento
Copy link
Contributor

@marcosbento marcosbento commented Dec 3, 2025

Description

An attempt to modernize the code base, by deprecating the "old style" NonCopyable in favour of explicitly deleting copy ctor/copy assignment operator.

This follows the advice of the CppCoreGuidelines, which states = delete is preferred -- see the discussion isocpp/CppCoreGuidelines#1354 (comment).

The proposed effectively remove a "small" eckit dependency

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

📖 Documentation 📖
https://sites.ecmwf.int/docs/dev-section/odc/pull-requests/PR-48

@marcosbento marcosbento force-pushed the feature/remove_noncopyable branch from 94efb78 to 4eff669 Compare December 3, 2025 15:03
@marcosbento marcosbento force-pushed the feature/remove_noncopyable branch from 4eff669 to cfba30a Compare December 3, 2025 15:06
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.91%. Comparing base (aafb8f0) to head (cfba30a).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #48      +/-   ##
===========================================
- Coverage    86.94%   86.91%   -0.03%     
===========================================
  Files          188      188              
  Lines        15116    15021      -95     
  Branches      1363     1363              
===========================================
- Hits         13142    13055      -87     
+ Misses        1974     1966       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@simondsmart simondsmart merged commit 022e0b1 into develop Dec 3, 2025
203 of 204 checks passed
@marcosbento marcosbento deleted the feature/remove_noncopyable branch December 3, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants