Skip to content

Conversation

@jinmannwong
Copy link

Description

The changes merged in #30 raises an error when arch dir doesn't exist. This is a small fix to allow the target of the symlink not to exist.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.66%. Comparing base (460350f) to head (9f9b1bc).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #35   +/-   ##
========================================
  Coverage    40.66%   40.66%           
========================================
  Files           48       48           
  Lines        10129    10129           
========================================
  Hits          4119     4119           
  Misses        6010     6010           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@wdeconinck wdeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks for this!

@wdeconinck wdeconinck merged commit 468b73c into develop Nov 3, 2025
7 checks passed
@jinmannwong jinmannwong deleted the fix/symlink-arch branch November 3, 2025 08:56
@jinmannwong
Copy link
Author

Would it be possible to have a new release with the recent changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants