Skip to content

Conversation

@jinmannwong
Copy link

Description

Incorrect relative path can be computed when one of the paths is itself a link as raised in #33. This PR addresses this issue by extracting the realpath first before computing the relative path.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@412dfa1). Learn more about missing BASE report.
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop      #34   +/-   ##
==========================================
  Coverage           ?   40.67%           
==========================================
  Files              ?       48           
  Lines              ?    10157           
  Branches           ?        0           
==========================================
  Hits               ?     4131           
  Misses             ?     6026           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jinmannwong jinmannwong deleted the fix/symlink_force-with-links branch October 31, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect symlink to bundle.yml with ecbundle create --src-dir=$PWD/source

3 participants