Open
Conversation
clessig
reviewed
Feb 11, 2026
Collaborator
clessig
left a comment
clessig
left a comment
There was a problem hiding this comment.
Some high level comments for the moment, need to make another pass to look at details.
| # training_mode: "masking", "student_teacher", "latent_loss" | ||
| training_mode: ["masking"] | ||
|
|
||
| # Collapse monitoring for detecting representation collapse |
Collaborator
There was a problem hiding this comment.
The default config is on forecasting so we shouldn't need this in there.
| if self.rampup_ratio is not None: | ||
| halflife_steps = min(halflife_steps, cur_step / self.rampup_ratio) | ||
| beta = 0.5 ** (self.batch_size / max(halflife_steps, 1e-6)) | ||
| return beta |
Collaborator
There was a problem hiding this comment.
Shouldn't we continuously update beta and store it as a class member variable, and just return it in the function.
|
|
||
| self.t_start = time.time() | ||
|
|
||
| def _compute_collapse_metrics(self, preds, targets_and_auxs) -> None: |
Collaborator
There was a problem hiding this comment.
Should be a separate class.
|
|
||
| # Get EMA beta from target_and_aux_calculators | ||
| for _calc_name, calculator in self.target_and_aux_calculators.items(): | ||
| if isinstance(calculator, EMATeacher): |
Collaborator
There was a problem hiding this comment.
It would be best if we could avoid isinstance()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduce monitoring the ranks and singular values of the latents (most code written by Claude, please check carefully at review time)
Issue Number
Closes #1813
Is this PR a draft? Mark it as draft.
Checklist before asking for review
./scripts/actions.sh lint./scripts/actions.sh unit-test./scripts/actions.sh integration-testlaunch-slurm.py --time 60