Open
Conversation
shmh40
approved these changes
Feb 6, 2026
Contributor
shmh40
left a comment
shmh40
left a comment
There was a problem hiding this comment.
Tested and doesn't cause problems for me.
clessig
requested changes
Feb 6, 2026
| # maybe_sharded_sd[param_name.replace("module.", "")] = nn.Parameter(sharded_tensor) | ||
| maybe_sharded_sd[param_name] = torch.nn.Parameter(sharded_tensor) | ||
| if sharded_meta_param is None: | ||
| logger.info(f"Sharding meta parameters is None for: {param_name}") |
Collaborator
There was a problem hiding this comment.
Is it correct that sharded_meta_param is None means that this is a parameter in the checkpoint that is not present in the current model?
| sharded_meta_param.placements, | ||
| ) | ||
| # maybe_sharded_sd[param_name.replace("module.", "")] = nn.Parameter(sharded_tensor) | ||
| maybe_sharded_sd[param_name] = torch.nn.Parameter(sharded_tensor) |
Collaborator
There was a problem hiding this comment.
Can we please remove the line below.
Collaborator
|
@kctezcan : can you address the comments so that we can merge this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See #1750
Issue Number
Closes #1750
Is this PR a draft? Mark it as draft.
Checklist before asking for review
./scripts/actions.sh lint./scripts/actions.sh unit-test./scripts/actions.sh integration-testlaunch-slurm.py --time 60