fix: improve input handling in workflow sync-milestones-labels.yml #429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Problem
The workflow was passing repositories as a single quoted string to -t flag:
-t "${{ inputs.repositories }}"
This resulted in repository names like 'zenoh-c eclipse-zenoh' being treated
as a single repository, causing 404 API errors with URL-encoded spaces (%20).
## Solution
Loop through space-separated repositories and pass each as a separate -t argument:
for repo in ${{ inputs.repositories }}; do
args+=(-t "$repo")
done
This matches the expected array format for yargs parser in github-sync.js.
## Changes
Applied fix to all 4 command invocations:
- Label sync (live run)
- Label sync (dry-run)
- Milestone sync (live run)
- Milestone sync (dry-run)
The labels input had the same issue as repositories. The -l flag in
github-sync.js expects an array, but labels were passed as a single
quoted string with spaces.
Labels are generated from pr-checklists.json keys joined with spaces:
join(" ") # produces: "api-sync" "breaking-change" "bug" ...
Fixed by looping through each label and passing as separate -l argument,
similar to the repositories fix. Applied to both label sync runs
(live and dry-run).
sashacmc
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix https://github.com/eclipse-zenoh/ci/actions/runs/20955157189/job/60217860798