Remote agent refactor cert provider #808
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderdjw
suggested changes
Sep 19, 2025
|
|
||
| // CertRequest represents a certificate creation request | ||
| type CertRequest struct { | ||
| TargetName string `json:"targetName"` |
Contributor
There was a problem hiding this comment.
can we name this field more generic? as a cert request, what does target name mean?
| * SPDX-License-Identifier: MIT | ||
| */ | ||
|
|
||
| package k8scert |
| if v, ok := properties["name"]; ok { | ||
| ret.Name = v | ||
| } | ||
| if v, ok := properties["inCluster"]; ok { |
Contributor
There was a problem hiding this comment.
if you only support inCluster, why you provide options here?
| // Set default duration if not specified | ||
| duration := req.Duration | ||
| if duration == 0 { | ||
| duration = 365 * 24 * time.Hour // 1 year default |
| } | ||
|
|
||
| // Create the certificate | ||
| certDER, err := x509.CreateCertificate(rand.Reader, &template, &template, &privateKey.PublicKey, privateKey) |
Contributor
There was a problem hiding this comment.
why you didn't use OSS cert-manager (certificate CR) to manipulate cert?
yanjiaxin534
force-pushed
the
remote-agent-refactor-cert-provider
branch
from
dffced2 to
8b2b2ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.