Fix node registration, filtergateway, and scenario processing bugs #400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modified find_node_by_simple_key() to skip invalid IPs (0.0.0.0, 127.0.0.1, empty) - Iterates through all nodes to find first valid IP instead of just returning first found - Added new find_node_by_target_ip() function for specific IP lookups - Prevents node registration from returning wrong/unusable IP addresses
…-pullpiri#389] - Check if scenario has valid conditions before subscribing to DDS topic - Skip subscription when topic name is empty to prevent dummy data - Added logging for skipped subscriptions for debugging - Fixes issue where empty conditions caused unwanted DDS data publishing
…i#386] - Changed apply() to return Vec<String> instead of single String - Collects all scenarios from multi-document YAML, not just the last one - Updated apply_artifact() to send all scenarios to FilterGateway - Updated tests to handle new return type - Fixes issue where only last scenario in YAML file was being processed
Contributor
There was a problem hiding this comment.
I deeply appreciate your contribution.
This section inserts a random node when the package fails to find a node to run on. As a result, the code shouldn't be executed, and it would be better to fundamentally change the part before this point.
| || ip_address == "127.0.0.1" | ||
| { | ||
| println!("Skipping invalid IP: {}", ip_address); | ||
| continue; |
Contributor
There was a problem hiding this comment.
Sometimes, IP can be 127.0.0.1 or 0.0.0.0.
Contributor
There was a problem hiding this comment.
Good.
However, no decision has yet been made on whether to allow multi-scenarios.
Contributor
|
@ANAVHEOBA Thanks for the contribution!! Unfortunately, you need Eclipse FDN for PR to be merged. So, you need to join Eclipse foundation and submit some materials for getting ECA. If you are still considering the contribution, please get Eclipse FDN/ECA. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses three open issues related to node registration, DDS subscription handling, and scenario processing.
Changes
#391 - Node registration wrong IP
find_node_by_simple_key()to filter out invalid IPs (0.0.0.0, 127.0.0.1, empty)#389 - Filtergateway condition bug
#386 - Scenario processing only last scenario
apply()to return all scenarios from YAML, not just the last oneTest Plan