Xiangzhou/fix issue make post request#15
Open
xiangzho72 wants to merge 32 commits intoeclipse-iofog:masterfrom
Open
Xiangzhou/fix issue make post request#15xiangzho72 wants to merge 32 commits intoeclipse-iofog:masterfrom
xiangzho72 wants to merge 32 commits intoeclipse-iofog:masterfrom
Conversation
Python SDK Updates for 1.3.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the error when calling make_post_request() by following suggestion from : https://stackoverflow.com/questions/13175253/python-error-type-error-post-data-should-be-bytes-also-user-agent-issue
Change iomessage::contextdata and contentdata from type 'bytearray' to 'string', otherwise, user has to use following :
msg.contentdata = bytearray('hello world'.encode()),
Rather than the more intuitive way below:
msg.contentdata = 'hello world'
my thought is those two fields should be like other fields in iomessage: string when processing, and transformed to bytearray just before sending to wire
Updated broken test cases. I have verified them in my local environment.
The change is branched from tag v2.0.1