Allowed JAR saving if proceedOnError is specified

[256p]

Added proceedOnError() check in order to allow JAR generation if -proceedOnError argument is passed.

[kriegaex]

@aclement, should this one be merged? I am not sure what it does.

For some reason I thought it was merged already, maybe because the previous PR #87 was closed. I even mentioned it in the 1.9.8 release notes, but am going to remove it for now.

[aclement]

The comment right above the change is /* Ensure we don't write an incomplete JAR bug-71339 */ so I'd say that bug at least needs reading. So I don't think it is an automatic merge, no.

[256p]

For some reason I thought it was merged already, maybe because the previous PR #87 was closed.

I closed the first PR because I have mistaken and my Eclipse Contributor Agreement was not validated.

[256p]

The comment right above the change is /* Ensure we don't write an incomplete JAR bug-71339 */ so I'd say that bug at least needs reading. So I don't think it is an automatic merge, no.

Maybe I am wrong but as I understand this bug was related to the build without -proceedOnError argument. And yes in some cases it might result in corrupted outjar. But isn't -proceedOnError argument supposed to return results regardless of errors?

[kriegaex]

as I understand this bug was related to the build without -proceedOnError argument. And yes in some cases it might result in corrupted outjar. But isn't -proceedOnError argument supposed to return results regardless of errors?

@aclement, I think @256p has a point here. How about logging a warning about a possibly corrupted JAR in case of -proceedOnError, but then continuing to write the file?

@256p, can you please provide a reasonable test case for which it makes sense to continue? A negative test which corrupts the file would also be welcome. That would help to move this issue along, because I think this deserves test coverage. If your test case is not automated, because you have trouble understanding the structure and configuration of AspectJ tests (which would not surprise me), at least reproducible examples, as minimal as possible, would be a good starting point for us to automate it. Depending on how important your authorship is for this PR, I could commit on top your commit of it or start from scratch.