Per-classloader weaving cache fails for classes generated for around advice types

[kriegaex]

Relates to #314.

[kriegaex]

@KimmingLau, I am busy relocating long-distance and do not have much time now. I pushed a commit extending an existing test, reproducing the problem. If you feel like taking a look, that would be terrific.

It looks as if this scenario was never tested before and hence never worked to begin with.

[KimmingLau]

Congratulations on the new house! I am also very interested in this problem, and I have reproduced it. I think the root cause of this problem is that the related generated class cached bytes (Here is Foo$AjcClosure1.class) was not define in advance before returning the class cached bytes (Here is Foo.class). By contrast, shard cache has done this operation in org.aspectj.weaver.tools.cache.SimpleCache#initializeClass(), so there is no such problem when using -Daj.weaving.cache.impl=shared.

[kriegaex]

Yes, the generated inner class is undefined, which is why the outer class referencing it cannot be fully loaded. If you look at the failure stack trace, you see no AspectJ classes in the trace at all, i.e. when the woven outer class is loaded in WeavedClassCache mode, the inner class is not loaded on time, whereas in SimpleCache (shared cache) mode, this happens by whatever means, maybe via defineClass, which does not exist equivalently in WeavedClassCache. The implementation is simply incomplete, I guess. It was never tested automatically before 2f9c242, therefore nobody noticed until the GitHub issue was raised.