Move hdf.object classes to their own plugin and fragment #598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Baha El-Kassaby <baha.elkassaby@gmail.com>
*Make ReadThreadTest equivalent class for dawnsci.hdf5 *Move WriteThreadTest and ATTestBase back to hdf5 plugin Signed-off-by: Baha El-Kassaby <baha.elkassaby@gmail.com>
PeterC-DLS
suggested changes
Sep 22, 2017
Contributor
PeterC-DLS
left a comment
PeterC-DLS
left a comment
There was a problem hiding this comment.
Just one extraneous line
| private void prepareForTest(String file, int nthreads) throws Exception { | ||
| HDF5FileFactory.deleteFile(file); | ||
|
|
||
| HDF5FileFactory.acquireFile(file, true); |
Contributor
Author
There was a problem hiding this comment.
Done. Can I merge?
Contributor
Author
|
could you change your review to a green check? :) |
PeterC-DLS
approved these changes
Sep 22, 2017
Contributor
|
@belkassaby: which repos does this affect? |
Contributor
|
Need to synchronise with these:
|
Contributor
Author
|
Hi Pete,
|
Contributor
|
Closing this for #604 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Baha El-Kassaby baha.elkassaby@gmail.com