-
Notifications
You must be signed in to change notification settings - Fork 12
[patch] source code for https://eclipse.dev/amlen/ #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
302631c to
56421dc
Compare
IanBoden
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we adding all the example site stuff?
| PROJECT_NAME = "<project_name>" // must be all lowercase. | ||
| PROJECT_BOT_NAME = "<Project_name> Bot" // Capitalize the name | ||
| PROJECT_GH_ORG = "<project_github_org>" // e.g. eclipse-hono | ||
| PROJECT_WEBSITE_REPO = "<project_website_repo>" // e.g. hono-website |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should these values have been filled in?
| PROJECT_BOT_NAME = "<Project_name> Bot" // Capitalize the name | ||
| PROJECT_GL_GROUP = "<project_gitlab_group>" // e.g. papyrus | ||
| PROJECT_WEBSITE_REPO = "<project_website_repo>" // e.g. papyrus-website | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and these?
| # show_events = true | ||
| # table_classes = "table table-bordered" | ||
| # hide_cfa_same_page = true | ||
| # show_collapsible_menu = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are these all commented out? should they be deleted?
| #headline: "" | ||
| #subtitle: "" | ||
| #tagline: "" | ||
| #links: [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
slightly odd to have commented out defaults in the defaults file isn't it?
| .alias('h', 'help') | ||
| .version('0.1') | ||
| .alias('v', 'version') | ||
| .epilog('Copyright 2019 Eclipse Foundation inc.').argv; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should the copyright be updated to 2026?
Source code for version of Amlen website at https://eclipse.dev/amlen/ that uses the Eclipse template and build system.
Currently you need to run the build outside the eclipse infrastructure and code the output (in the public directory to the amlen-website repo). I started working on a job to do this automatically in the buildcontainer directory but it doesn't work yet:
https://ci.eclipse.org/amlen/job/HouseKeeping_UpdateMainWebsite/1/
But I want to get the website source code in and then work on the jenkins build separately (the website is already live)