This repository was archived by the owner on Jun 18, 2025. It is now read-only.
Added ERC20 support #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
14
to
21
| function _transferERC20(address tokenAddress, uint256 amount, address from, address to) internal { | ||
| ERC20 token = ERC20(tokenAddress); | ||
| if (address(this) == from) { | ||
| token.transfer(to, amount); | ||
| } else { | ||
| token.transferFrom(from, to, amount); | ||
| } | ||
| } |
Check failure
Code scanning / Slither
Unchecked transfer
Comment on lines
14
to
21
| function _transferERC20(address tokenAddress, uint256 amount, address from, address to) internal { | ||
| ERC20 token = ERC20(tokenAddress); | ||
| if (address(this) == from) { | ||
| token.transfer(to, amount); | ||
| } else { | ||
| token.transferFrom(from, to, amount); | ||
| } | ||
| } |
Check failure
Code scanning / Slither
Unchecked transfer
Changes to gas cost
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
|
Coverage after merging feature/dev-339 into feature/blast will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Coverage after merging feature/dev-339 into feature/blast will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Coverage after merging feature/dev-339 into feature/blast will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
Author
|
@0xjohnnycagewins added token type |
|
Coverage after merging feature/dev-339 into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
added tests # Conflicts: # test/EdgeCasesTest.t.sol # test/utils/OfferUtils.sol
GabrielCartier
force-pushed
the
feature/dev-339
branch
from
3296a72 to
04e8936
Compare
|
Coverage after merging feature/dev-339 into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.