NotWorking: Attempt at navigatoreContent extension#26
Open
nickl- wants to merge 1 commit intoecd-plugin:masterfrom
Open
NotWorking: Attempt at navigatoreContent extension#26nickl- wants to merge 1 commit intoecd-plugin:masterfrom
nickl- wants to merge 1 commit intoecd-plugin:masterfrom
Conversation
Collaborator
|
Thank you very much for working on this, but I might not have the time to look at this for the next few days, but will do. |
Author
|
No worries, take your time. As mentioned it is not perfect but it should at least do something. Perhaps my testing procedure is faulty I tried via Plugins -> Launch eclipse.... and installing a new plugin from the compiled source folder but neither would produce any changes. Unless I can see that I am changing something I have no idea how to go forward with this. Thought I'd at least submit what I've done maybe you can see something I am not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per issues #25 I attempted to create a
navigatorContentextension for browsing jar files.The implementation is not perfect but it should at least do something. If nothing else I would've been pleased with some sort of exception but nada...
Not sure what to try next?!?!?
I included the an attribute I found to set the decompiler association by default, this does seem to work but it could also just be cache that is allowing this to association to be set, again I cannot be sure.
Submitting this for fresh eyes who may be able to spot something I may have done wrong or something that I missing as I cannot think of anything else to try. It simply does nothing.