This repository was archived by the owner on Jun 27, 2023. It is now read-only.
Add support for buster rootPath configuration options#7
Open
rowanbeentje wants to merge 4 commits intoebi:masterfrom
Open
Add support for buster rootPath configuration options#7rowanbeentje wants to merge 4 commits intoebi:masterfrom
rowanbeentje wants to merge 4 commits intoebi:masterfrom
Conversation
Owner
|
This seems to fail if no rootPath was set? |
Fall back to the old behaviour including process.cwd() usage
Author
|
You're quite right – it would potentially also change the behaviour with a default blank rootPath, as the old method used process.cwd(). I believe I've fixed that in 91bb250 - sorry about that. |
|
+1 Please merge and release this :) |
Owner
|
Sorry my time for this is very limited at the moment. I promised to merge and release it until next sunday :) |
|
Have you had a chance to test this @ebi? |
|
We just ran into the same issue and fixed it locally. Would be nice if this was merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The buster.js configuration supports a rootPath, which specifies the root directory in which source files live. If this is specified, buster resolves all paths against this root.
buster-coverage currently doesn't support this rootPath option, so that coverage tests have to specify files using different paths, or based on where the buster command is being originally run from.
These commits by @gugu and @rowanbeentje add support for the rootPath option.