Skip to content

Conversation

@MarkMelotto
Copy link
Contributor

added rich dependency to the environment yml.
@sverhoeven please check if it is done like this, or if there is a better way

added rich dependency to the environment yml.
@MarkMelotto MarkMelotto requested a review from sverhoeven March 10, 2025 08:49
@MarkMelotto
Copy link
Contributor Author

maybe this can also be changed?
in environment.yml:
# Use fork of ewatercycle-hbv
- ewatercycle-HBV@git+https://github.com/eWaterCycle/ewatercycle-hbv@main

Copy link
Member

@sverhoeven sverhoeven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will work.
Alternative is to use https://anaconda.org/conda-forge/rich , but this could cause conda conflicts, while pip is more forgiving.

@sverhoeven
Copy link
Member

maybe this can also be changed? in environment.yml: # Use fork of ewatercycle-hbv - ewatercycle-HBV@git+https://github.com/eWaterCycle/ewatercycle-hbv@main

The latest version on https://pypi.org/project/ewatercycle-HBV/ is from 6 Sept 2024, if that contains all the things you need then replace the line with ewatercycle-hbv==1.8.5. Is see https://github.com/eWaterCycle/ewatercycle-hbv has a lot of commits after 6 Sept 2024 that are not present on pypi. So I would keep it as is, until a new version of ewatercycle-hbv is published to pypi.

@MarkMelotto MarkMelotto merged commit 7aab8a7 into main Mar 10, 2025
1 check passed
@MarkMelotto MarkMelotto deleted the add-rich branch March 10, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants