Draft
Conversation
Portevent
requested changes
Jan 2, 2024
Portevent
approved these changes
Jan 2, 2024
aaryswastaken
commented
Jan 2, 2024
Member
Author
aaryswastaken
left a comment
aaryswastaken
left a comment
There was a problem hiding this comment.
Need better backend architecture
|
|
||
| self.bind = None | ||
| self.vers = 0x0001 | ||
| self.pub = None |
Member
Author
There was a problem hiding this comment.
Implement the usage of a whole backend rather than the bear key.
Will implement in ether.backend.local
Maybe implement backend choice better in client.py ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
beginning of the code
argument management is a bit trash for now