DEV: Added new json body pattern builder and test#35
Merged
prasanthkv merged 2 commits intoeBay:masterfrom Aug 21, 2025
Merged
Conversation
prasanthkv
previously approved these changes
Aug 20, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new JSON body pattern builder for masking entire nested JSON objects (e.g., credit card numbers), enhances the documentation with comprehensive links to all available pattern builders, and bumps the project version.
- Added
JsonBodyPatternBuilderclass with regex-based masking for JSON nested objects - Updated README.md to replace the old bullet list with hyperlinked pattern builder references
- Incremented version from 2.0.1 to 2.0.2 in pom.xml
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pom.xml | Version bump from 2.0.1 to 2.0.2 |
| JsonBodyPatternBuilderTest.java | Comprehensive test suite for the new JsonBodyPatternBuilder with various JSON formatting scenarios |
| JsonBodyPatternBuilder.java | New pattern builder implementation for masking entire JSON object values |
| README.md | Updated documentation with hyperlinked references to all available pattern builders |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...extensions/src/main/java/com/ebay/ejmask/extenstion/builder/json/JsonBodyPatternBuilder.java
Outdated
Show resolved
Hide resolved
...extensions/src/main/java/com/ebay/ejmask/extenstion/builder/json/JsonBodyPatternBuilder.java
Show resolved
Hide resolved
sumanthreddybandi
approved these changes
Aug 21, 2025
prasanthkv
approved these changes
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This pull request introduces a new pattern builder for masking JSON bodies, updates the documentation to reflect the available pattern builders, and adds comprehensive tests for the new functionality. The main goal is to enhance support for masking sensitive data in JSON objects by providing a dedicated builder and ensuring its correctness.
Proposed Changes
JsonBodyPatternBuilderclass to provide regex-based masking for JSON bodies, supporting cases like masking entire nested objects (e.g., credit card numbers).README.mdto include links to all available pattern builders, including the newJsonBodyPatternBuilderand others, with direct references to their source files.Test Plan
Added
JsonBodyPatternBuilderTestto do the test.