Skip to content

Capture ERP Error Messages in Order Comment#63

Open
DWDBE wants to merge 3 commits intomainfrom
dbe/27370-Capture-ERP-Error-Messages-in-Order-Comment
Open

Capture ERP Error Messages in Order Comment#63
DWDBE wants to merge 3 commits intomainfrom
dbe/27370-Capture-ERP-Error-Messages-in-Order-Comment

Conversation

@DWDBE
Copy link
Contributor

@DWDBE DWDBE commented Feb 20, 2026

No description provided.

@DWDBE DWDBE requested a review from frederik5480 as a code owner February 20, 2026 11:32
@nicped nicped requested a review from mbengtson February 20, 2026 12:10
@nicped
Copy link
Member

nicped commented Feb 20, 2026

I am not fan of using Message - an order has 2 messages - Comment and CustomerComment which can both be part of checkout flow - and this code overwrites what is in the field.

If having this information on the orderdebugging info is not enough, I propose to create either a specific field on the order IntegrationLastCommunicationMessage or whatever - or maybe a separate table with ERP communication history.

@DWDBE
Copy link
Contributor Author

DWDBE commented Feb 20, 2026

I am not fan of using Message - an order has 2 messages - Comment and CustomerComment which can both be part of checkout flow - and this code overwrites what is in the field.

If having this information on the orderdebugging info is not enough, I propose to create either a specific field on the order IntegrationLastCommunicationMessage or whatever - or maybe a separate table with ERP communication history.

The code Appends the error message to the existing Comment value, it doesn't overwrite the Comment field content

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants