Add scrollbar styles export#2327
Open
Kamalpannu wants to merge 1 commit intodxc-technology:masterfrom
Open
Conversation
Author
|
Hi @GomezIvann, just checking in to see if you had a chance to review this PR. |
Collaborator
|
Hello @Kamalpannu, |
Mil4n0r
requested changes
Dec 19, 2025
Comment on lines
+37
to
+39
| "dependencies": { | ||
| "@dxc-technology/halstack-react": "^0.0.0" | ||
| } |
| export { default as DxcWizard } from "./wizard/Wizard"; | ||
| export { HalstackProvider, HalstackLanguageContext } from "./HalstackContext"; | ||
| export { default as useToast } from "./toast/useToast"; | ||
| export { default as scrollbarStyles } from "./styles/scroll"; |
Collaborator
There was a problem hiding this comment.
This seems like a valid idea, however we should update the documentation to let the user know that he can import this mixin for his custom components. I will check where we can insert this information.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
(Check off all the items before submitting)
/libdirectory./websiteas needed.Purpose
Fix the issue with missing
scrollbarStylesexport so it can be imported correctly inindex.ts.Description
scrollbarStylesexport insrc/index.ts./libpass successfully.Screenshots
Not applicable.
Additional context
The import
./styles/scrollbarStyleswas missing, causing TS build failures in the library.**Closes #2190 **