Merged
Conversation
Mil4n0r
requested changes
May 23, 2025
Mil4n0r
requested changes
May 26, 2025
Collaborator
Mil4n0r
left a comment
There was a problem hiding this comment.
Looks good to me. However, can you do a change in the stories so that we have both an example of top/left icon position with text and another one with no text? (instead of replacing it like you have done). That way we canmake sure that we are covering all scenarios.
Collaborator
Author
We do have already a few examples with icon and label with iconPosition top and left. |
Mil4n0r
approved these changes
May 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
(Check off all the items before submitting)
/libdirectory./websiteas needed.Purpose
To avoid creating a breaking change for now we will default the
tabIdvalue to the label if this one is set.