Conversation
Mil4n0r
requested changes
May 2, 2025
Collaborator
Mil4n0r
left a comment
Mil4n0r
left a comment
There was a problem hiding this comment.
Apart from the minor fixes. We should add somewhere in the documentation of tokens that, in case they are overwritten, this must be done with px units for the new logic inside Datagrid to work.
Mil4n0r
requested changes
May 2, 2025
apps/website/screens/components/data-grid/DataGridPageLayout.tsx
Outdated
Show resolved
Hide resolved
apps/website/screens/components/data-grid/overview/DataGridOverviewPage.tsx
Outdated
Show resolved
Hide resolved
apps/website/screens/components/data-grid/overview/DataGridOverviewPage.tsx
Outdated
Show resolved
Hide resolved
apps/website/screens/components/data-grid/overview/DataGridOverviewPage.tsx
Outdated
Show resolved
Hide resolved
apps/website/screens/components/data-grid/overview/DataGridOverviewPage.tsx
Outdated
Show resolved
Hide resolved
apps/website/screens/components/data-grid/overview/DataGridOverviewPage.tsx
Show resolved
Hide resolved
Collaborator
|
Only hierarchical grid doc missing now. |
Mil4n0r
approved these changes
May 29, 2025
Mil4n0r
requested changes
May 29, 2025
Collaborator
Mil4n0r
left a comment
Mil4n0r
left a comment
There was a problem hiding this comment.
Chromatic story is displaying no content.
Mil4n0r
approved these changes
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
/libdirectory./websiteas needed.Description
Redesign of datagrid component, following the new design kit specifications, already using the new token architecture (CSS variables). Action icon is updated in a different PR.
Additional context
Figma designs