Conversation
New needed types are added to improve integration with typescript
Update useHalResource hook with the new types
marcialfps
requested review from
GomezIvann,
Jialecl,
jsuarezgonz,
kukoc and
raquelarrojo
kukoc
reviewed
Jan 26, 2024
|
|
||
| export type RequestStatus = "idle" | "fetching" | "resolved" | "rejected" | "interaction"; | ||
|
|
||
| type InteractionType = Record<string, unknown> & { |
Collaborator
There was a problem hiding this comment.
Hi @marcialfps , We believe it would be better to move everything from line 27 to 109 to a separate Halstack -client types library.
Also will investigate how to contribute to the public npm or @types and push all the types we are exporting from Halstack libraries, including hasltack-react-hal and even the halstack-react-cdk.
We will start and spike to learn more about @types and agree on the best approach moving forward. I would keep this PR on Hold for the time being if that's ok with you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since other teams are adopting Typescript in their UIs, we need the hook
useHalResourceto return a correctly typed array.Changes
useHalResourcewith the new types.